Fix pnpcontext cache did not work for multitenant #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 13, 2021 17:46
…for each tenant and be able to check in GetPnPContext if the given context uses the same Authentication flow (App/User, etc)
…tored in ctxSettings.AuthenticationManager as otherwise we would need to cache PnPContext by Authflow and tenant in order to make sure we always get the right pnpcontext when convert back in GetPnPContext
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way we had the pnpContextCached in PnPCoreSdk we would get potentialy wrong pnpcontext as we cloud have GetClientContext started from User or App Only Context.