Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CreateFolderInList Handle Error "To update this folder, go to the channel in Microsoft Teams" #470

Merged
merged 2 commits into from
Oct 29, 2021

Conversation

czullu
Copy link
Contributor

@czullu czullu commented Sep 23, 2021

creating subfolder to channel folder does fail as ContentType, Properties and PropertyBag Update on Channel Folder is not allowed.
The suggested fix does catch the specific error, logs it as warning and continues to create folder structure

@czullu
Copy link
Contributor Author

czullu commented Oct 5, 2021

@jansenbe Hi Bert, since you didn't merge this pull request, I suspect you have some concerns about handling the update error for Team Channel Folders. The only other way I can think of is to pre-check if the "vti_x005f_teamchannelurl" property is present in the folder, and skip any possible updates from the template for the ChannelFolder itself to create the subfolders as specified in the template. I can change the code if this is the way you would prefer it.

@jansenbe
Copy link
Contributor

jansenbe commented Oct 6, 2021

@czullu : this one would need some more review time, hence I did not yet merge it. Hope to have more time in the coming days

@jansenbe jansenbe self-assigned this Oct 6, 2021
jansenbe added a commit that referenced this pull request Oct 29, 2021
@jansenbe jansenbe merged commit ee0a4e6 into pnp:dev Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants