Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UrlEncode/Decode Issues with special char #506

Merged
merged 2 commits into from
Oct 29, 2021

Conversation

czullu
Copy link
Contributor

@czullu czullu commented Oct 19, 2021

Replace WebUtility.UrlDecode and HttpUtility.UrlDecode with Uri.UnescapeDataString
Replace WebUtility.UrlEncode and HttpUtility.UrlEncode with Uri.EscapeDataString

Our Tests did show that Uri.EscapeDataString and Uri.UnescapeDataString does handle special char like + or #, % in all tested cases correct while the other functions for example remove + sign in Urls

…apeDataString

Replace WebUtility.UrlEncode and HttpUtility.UrlEncode with Uri.EscapeDataString
@czullu czullu changed the title Fix UrlEncode/Decode Issues with Fix UrlEncode/Decode Issues with special char Oct 19, 2021
jansenbe added a commit that referenced this pull request Oct 29, 2021
@jansenbe jansenbe merged commit c545b65 into pnp:dev Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants