Fix issues exporting channels and tabs with TeamsAppId and Description #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When exporting Team Channels and Tabs, TeamsAppId is never retrieved, same way, when the Channel Description is null, description attribute is missing. Both attributes are required and if missing make the template not loading.
6 tasks
|
Nice work @magarma ! |
|
Until this makes it into the released version, is there a trick we can use to get the correct |
|
There is a nightly build, you could try to use that until the 1.8 is released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
When exporting Team Channels and Tabs, TeamsAppId for the Tab is never retrieved, also, when the Channel Description is null, the Channel description attribute is missing.
Both attributes are required and if they are missing, trying to apply the template, it fails.
There is an opened issue about it.
#444
I've changed the way that the solution gets the app id to reuse an exiting method that was already in the class.
This is related with this change
#189
Now, both attributes are provided.
