Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catching File.NotFound exception to prevent error during export #573

Merged
merged 1 commit into from
Feb 7, 2022

Conversation

magarma
Copy link
Contributor

@magarma magarma commented Jan 13, 2022

Exporting a client side page with a thumbnail page containing a GUID in the URL is failing if it's not a SP Url.
Catching the exception to continue with the export.

Related with this issue
#568

Exporting a client side page with a thumbnail page containing a GUID in the URL is failing if it's not a SP Url.
Catching the exception to continue with the export.
@magarma
Copy link
Contributor Author

magarma commented Feb 4, 2022

@jansenbe @patrick-rodgers
I've notice that PRs in the project are not being accepted since early January, do we have an estimated time for reviewing these PRs?
Particularly, this PR is quite important for us, any O365 stock image selected as a thumbnail in a page breaks the export template.
I was hoping to use a nightly build in UAT, just asking if there is an estimated time or any information that can be useful for us to plan the release...

@jansenbe jansenbe self-assigned this Feb 7, 2022
jansenbe added a commit that referenced this pull request Feb 7, 2022
@jansenbe jansenbe merged commit ce0019b into pnp:dev Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants