Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve the target list by url for handler ObjectListInstanceDataRows #607

Merged
merged 1 commit into from
Mar 24, 2022

Conversation

BollietMZK
Copy link
Contributor

@BollietMZK BollietMZK commented Feb 17, 2022

The target list was retrieved with GetByTitle instead of retrieve it with GetListByUrl.
This behavior causes errors for native lists (like Events) whose title is translated according to the language of the site (Événements in French).

Fix #606

The title is localized and failed for non-english site collections.
@BollietMZK BollietMZK changed the title Retrieve the target list by url for handler ObjectListInstanceDataRows Retrieve the target list by url for handler ObjectListInstanceDataRows #606 Feb 17, 2022
@BollietMZK BollietMZK changed the title Retrieve the target list by url for handler ObjectListInstanceDataRows #606 Retrieve the target list by url for handler ObjectListInstanceDataRows Feb 17, 2022
@jansenbe jansenbe self-assigned this Mar 24, 2022
@jansenbe
Copy link
Contributor

Good fix @BollietMZK , thanks for sharing this one.

jansenbe added a commit that referenced this pull request Mar 24, 2022
@jansenbe jansenbe merged commit 33274b6 into pnp:dev Mar 24, 2022
@BollietMZK BollietMZK deleted the fix/DataRowsListByUrl branch April 7, 2022 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Object Handler ListInstanceDataRows does not work for some native lists
2 participants