Fix for using passed PnPMonitoredScope in async method #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this Pull Request?
This PR fixes an issue which occurred when passing a PnPMonitoredScope as a parameter to an async method and then trying to use that passed scope to log messages. Since PnPMonitoredScope was using an internal ThreadStatic variable the async method could not access that variable if switching threads when doing some async work. Making the variable AsyncLocal instead should accomplish somewhat the same thing but making it usable with async work while still creating a new TopScope if used in different threads outside of the same async code flow.