Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to not re-throw caught exception during provisioning #668

Merged
merged 1 commit into from
Jun 8, 2022

Conversation

patrikhellgren
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
New sample? no
Related issues?

What's in this Pull Request?

This PR changes so that a caught exception during provisioning is not re-thrown which would cause the stack trace to be reset and it was much harder to troubleshoot where the exception originally occurred.

@jansenbe
Copy link
Contributor

jansenbe commented Jun 8, 2022

Nice catch @patrikhellgren

jansenbe added a commit that referenced this pull request Jun 8, 2022
@jansenbe jansenbe merged commit 6c76dcc into pnp:dev Jun 8, 2022
@patrikhellgren patrikhellgren deleted the fix-rethrow branch September 13, 2022 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants