Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to exporting renamed Title columns to a PnP template #776

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

jackpoz
Copy link
Contributor

@jackpoz jackpoz commented Oct 25, 2022

Add support to exporting renamed Title columns to a PnP template by not excluding the field when generating a template.
The Title will be included as a FieldRef like below

<pnp:FieldRefs>
    <pnp:FieldRef ID="fa564e0f-0c70-4ab9-b863-0177e6ddd247" Name="Title" Required="true" DisplayName="Renamed title" />
</pnp:FieldRefs>

The field changes are already applied by the provisioning engine so no changes are required there.

I have found some old discussions about this change with different opinions. I hope it will be considered as a good addition.

jansenbe added a commit that referenced this pull request Oct 26, 2022
@jansenbe jansenbe merged commit c91807a into pnp:dev Oct 26, 2022
@jackpoz
Copy link
Contributor Author

jackpoz commented Oct 26, 2022

Today I found out that this also fixes applying a template with a calculated column that references a renamed Title, where before it was throwing an exception "Your formula is referencing an invalid column" (formulas use the DisplayName)

@anthonywhite
Copy link

@jackpoz @jansenbe guess this will mean my suggestion #331 can also be closed? 🙂

@jackpoz
Copy link
Contributor Author

jackpoz commented Nov 21, 2022

I would say so as it implements it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants