Fix for infinite loop in Replacing Tokens when property values contain the Regex special char "$" #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation only escapes "$0" and will not escape other Regex $ expressions (e.g. "$", "$1", "$2")
Doing property.Value.Replace("$", "$$") ensures all $ chars are escaped from property value.
Autophanous
changed the title
Autophanous
changed the title
jansenbe
added a commit
that referenced
this pull request
Nov 7, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation only escapes property values containing "$0" and will not escape other Regex $ expressions (e.g. "$", "$1", "$2").
These unescaped Regex $ expressions will be replaced with the whole match value and cause an infinite loop.
Doing property.Value.Replace("$", "$$") ensures all $ chars are properly escaped from the property value.
E.g.
property.Value = "with a market value estimated to be worth $ 50 billion by 2025" will be replaced by "with a market value estimated to be worth with a market value estimated to be worth $ 50 billion by 2025 50 billion by 2025"