fix LocalizationToken.GetReplaceValue: fallback to old logic #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efaultLCID has always a Value i.e. 0 or the correct LCID and will throw a error when
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fallback to old logic as for me _defaultLCID has always a Value i.e. 0 or the correct LCID and will throw a error when defaultEntry is null because of the way resources are loaded. You can see first 2 have only one ResourceEntries in specific language and last one has 2 Entries. In case of a EN Default site the second LocalizationToken would fail to load - therefore the fallback.