fix(provisioning): non-taxonomy default folder values cause error #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored by: Szymon Sochocki <szymon.sochocki@core.co.uk>
|
@JakeStanger : nice improvement, thanks for sharing this! |
jansenbe
added a commit
that referenced
this pull request
Sep 21, 2023
|
I attempted to co-author the commit but I don't think it worked, but credit goes to @fidesimon for finding this and providing an initial fix |
JakeStanger
pushed a commit
to JakeStanger/pnpframework
that referenced
this pull request
Oct 17, 2023
Fixes an error introduced by my previous fix in pnp#915.
JakeStanger
pushed a commit
to JakeStanger/pnpframework
that referenced
this pull request
Oct 18, 2023
Fixes two errors introduced by my previous fix in pnp#915.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in the provisioning engine where default folder values would crash for any field type other than metadata.