Feature #1580, Docker Image

[shurick81]

Type

• Bug Fix
• New Feature
• Sample

Related Issues?

Completes #1580

What is in this Pull Request ?

Docker image with PnP.PowerSshell is published to Docker Hub

[erwinvanhunen]

@shurick81: can you explain the use of the release.yml action/workflow? I see the addition to the nightlyrelease workflow, but I do not see easily what the release.yml one is doing?

[shurick81]

Hi @erwinvanhunen, let me put it like this.

This is what we now have in https://github.com/pnp/powershell:

Release Type	Module Build in Pipeline	Publishing to the PS Gallery in Pipeline	Publishing to the Docker Hub in Pipeline	Pipeline
Nightly Releases	✅	✅	⬜	nightlyrelease.yml
Supported Releases	⬜	⬜	⬜	#N/A

Here's what I offer in the PR:

Release Type	Module Build in Pipeline	Publishing to the PS Gallery in Pipeline	Publishing to the Docker Hub in Pipeline	Pipeline
Nightly Releases	✅	✅	✅	nightlyrelease.yml
Supported Releases	⬜	⬜	✅	release.yml

Later on there will be opportunity to put more things in release.yml. Does it make sense?

[shurick81]

I have also added user documentation, here's how it looks on the Docker Hub: https://hub.docker.com/r/asapozhkov/powershell.
It should be copied manually from the md document: https://raw.githubusercontent.com/alexsapozhkov/powershell/dev/docker/hub.docker.md.

I also added a few lines here: https://github.com/alexsapozhkov/powershell/blob/dev/pages/index.md

[gautamdsheth]

@shurick81 - much clearer thanks !!

What I didnt understand about the release action(release.yml) is the CRON value.

Why are you releasing it everyday at 3:30 ? Did you mean it every 30 days or something ? Unless I am completely mistaken.
The thing is, we dont have a fixed release cadence, however much we would like to unfortunately :(

So, major release usually happens every 2-3 months and we dont have a fixed date/time for it.
Can you please change it a manual one instead ? I will try to trigger it at every release

[shurick81]

Hi @gautamdsheth, the logic behind is that this job that we can run daily is smart enough and it is identifying those versions of the module that are published in PS Gallery but not published yet in Docker Hub. So it should be fine to run it automatically and it will eventually publish a new module version. However, if you want to run it manually anyway, there is no problem, I can remove the CRON value.

[gautamdsheth]

Thank you @shurick81 , have merged the PR !
Looks great !

One request though :)

If you have some time, could be also please write an article (100 level) on how to go about using this ? Basic stuff for people new to Docker and all .

You can write it in markdown and add it here ?

https://github.com/pnp/powershell/tree/dev/pages/articles

This is a request, you can totally ignore it :)

Also, if you are interested, would you like to demo it in a PnP Community call, would love to see it in action ? We can help with that.

Thank you so much again for the amazing work 🙏😊

[shurick81]

Hi @gautamdsheth we already have some documentation here: https://pnp.github.io/powershell/. But probably we could mention that before using this Docker image, one needs to have Docker engine installed?