Consistency when retrieving Site Group by name (Closes #1721) #1808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onsistent null checks with exceptions.
|
Awesome , thanks @martinlingstuyl for this update ! Didn't think myself that a case sensitivity issue would go so far, earlier I just thought that maybe a |
|
It's new for me as well. Another solution would have been to load the titles of all sitegroups in memory, and then compare them clientside with Case Sensitivity disabled... but well, that just feels wrong, doesn't it? 😂 anyway, if there happens to be a better approach, we can change it again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consistency when retrieving Site Group by name.
Type
Related Issues?
Fixes #1721
What is in this Pull Request ?
Added some consistency between
Get-PnPGroup,Get-PnPGroupPermissionsandSet-PnPGroupPermissionscommandlets. When using the name parameter, the group is queried through the PnP Core SDK, which is case sensitive. Also added consistentnullchecks withPSArgumentExceptionswhen group was not found.