Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: bump to .NET 6 #2292

Merged
merged 27 commits into from
Dec 4, 2022
Merged

Conversation

gautamdsheth
Copy link
Collaborator

Type

  • Bug Fix
  • New Feature
  • Sample

Related Issues?

NA

What is in this Pull Request ?

Updates the project to support .NET 6 since .NET core 3.1 is getting out of support

@KoenZomers
Copy link
Collaborator

Compiles in VS Code, compiles in VS20212
Works in Azure Functions when setting it to PowerShell 7.2, does not work under PowerShell 7.0
Does not currently work in Azure Automation Runbooks

@gautamdsheth
Copy link
Collaborator Author

gautamdsheth commented Sep 11, 2022

@KoenZomers - can you give it a try whenever you have sometime on Azure runbooks and functions ? Added some backward compatibility so that it continues to work on older runtimes. Will also have to edit the build-nightly.ps1 file as well to update the path.

@KoenZomers
Copy link
Collaborator

As discussed, this one will be merged shortly after the 1.12 release as the current Azure Functions, even v4, even PS7.2, are using an old, deprecated DLL which prevent us from making this version work under it.

@KoenZomers
Copy link
Collaborator

Works well on Azure Functions with PowerShell 7.2 support which are to be release in January.
Works almost well on Azure Runbooks with PowerShell 7,2. Still some last quirks to iron out.

@gautamdsheth gautamdsheth merged commit 4098793 into pnp:dev Dec 4, 2022
@jebalert
Copy link

Have implications been considered when it comes to running this in an Azure Function in other environments outside of the commercial space? E.g., Gov Clouds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants