Feature: added support for shared channel creation #2308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gautamdsheth Wouldn't it be better to use "Standard" instead of "Public" for the standard channels? This way it is also aligned with how Microsoft documents the different channel types. "Public" might lead to some confusions, as it doesn't appear in any Microsoft documentation. |
|
Fair point @Studermarc, I have updated the code according to your suggestion @gautamdsheth fixed some bugs with the paramsets, tested the cmdlet, updated the documentation and added a changelog entry. If you agree with these changes, go ahead and merge. |
|
Looks good to me ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Related Issues?
NA
What is in this Pull Request ?
Added support for shared channel creation.
Made -Private parameter obsolete, instead will use TeamMemberShipType parameter.
For some reason, the API is throwing unknown error at the moment, am I missing something ?