Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to Remove-PnPSiteCollectionAppCatalog to remove app catalog by Site Id #2452

Merged
merged 2 commits into from
Oct 11, 2022

Conversation

jackpoz
Copy link
Contributor

@jackpoz jackpoz commented Oct 11, 2022

Type

  • Bug Fix
  • New Feature
  • Sample

Related Issues?

No related issues

What is in this Pull Request ?

Add support to Remove-PnPSiteCollectionAppCatalog to remove app catalog by Site Id by calling SiteCollectionAppCatalogsSites.RemoveById(guid) instead of Remove(url). This is needed when a site with an app catalog has the Url renamed or gets deleted.
Prefer RemoveById(guid) method when passing

New behavior with deleted site, the app catalog can be deleted:
image

Old behavior with deleted site, an error is thrown:
image

Old behavior with site deleted and recreated, the app catalog is not deleted:

@jackpoz jackpoz force-pushed the feature/RemoveAppCatalogById branch from 5d14f39 to fa1952a Compare October 11, 2022 15:30
@gautamdsheth gautamdsheth merged commit 5a48401 into pnp:dev Oct 11, 2022
@gautamdsheth
Copy link
Collaborator

Thanks @jackpoz, merged it !

Awesome find, thanks for sharing this 😊🙏

@jackpoz jackpoz deleted the feature/RemoveAppCatalogById branch December 4, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants