Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LivePersona is not working in spfx project #1241

Closed
muppanasashikumar opened this issue Jun 21, 2022 · 29 comments · Fixed by #1246
Closed

LivePersona is not working in spfx project #1241

muppanasashikumar opened this issue Jun 21, 2022 · 29 comments · Fixed by #1246
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:bug

Comments

@muppanasashikumar
Copy link

muppanasashikumar commented Jun 21, 2022

Thank you for reporting an issue, suggesting an enhancement, or asking a question. We appreciate your feedback - to help the team understand your
needs please complete the below template to ensure we have the details to help. Thanks!

Please check out the documentation to see if your question is already addressed there. This will help us ensure our documentation is up to date.

Category

[ ] Enhancement

[ ] Bug

[ ] Question

Version

Please specify what version of the library you are using: [ 3.8.0" ]

Expected / Desired Behavior / Question

Expected behavior: When Hovered on the persona the card details should pop up.

Observed Behavior

When hovered nothing is happening. Earlier it was working as expected but suddenly it stopped working.

Steps to Reproduce

"@microsoft/sp-core-library": "1.13.1", "@microsoft/sp-lodash-subset": "1.13.1", "@microsoft/sp-office-ui-fabric-core": "1.13.1", "@microsoft/sp-property-pane": "1.13.1", "@microsoft/sp-webpart-base": "1.13.1", "@pnp/common": "^2.8.0", "@pnp/logging": "^2.8.0", "@pnp/sp": "^2.13.0", "@pnp/spfx-controls-react": "^3.8.0", "@pnp/spfx-property-controls": "^3.2.0", "bootstrap": "^5.1.1", "office-ui-fabric-react": "7.174.1",

Thanks!

@ghost
Copy link

ghost commented Jun 21, 2022

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Jun 21, 2022
@github-actions
Copy link

Thank you for submitting your first issue to this project.

@divosuplente
Copy link

I confirm that the component is not working. We use a custom component based on the library's LivePersona component. It suddenly stopped working like 2 days ago. No LiveCard is shown when hovering over user coins. No errors are shown in console.

@Chipui-Kasar
Copy link

I started facing this issue yesterday. Let's wait for their update, hope they'll fix it ASAP.

@divosuplente
Copy link

Actually, I think there's nothing the team can do to fix it. The control uses a Sharepoint component for it, and my guess is that it is that component that has suddenly stopped working. The LiveCard component this library provides is based on it

@frankyvc
Copy link

+1 I'm having the same issue. Hopefully there is a quick fix, because this is a blocking issue for my client :( .

@AZNak
Copy link

AZNak commented Jun 22, 2022

+1 same issue here

@Vighough
Copy link

+1 same here, it seems that it has stopped working on a lot of tenants on the same time. That makes me assume that it not caused by a gradually rolled out update but rather a switch that Microsoft may have turned off

@SharePickle
Copy link
Contributor

SharePickle commented Jun 23, 2022

It looks like Microsoft renamed property upn to legacyUpn.
Either fix it by changing component's property or maybe MS should change it back to upn?

@frankyvc
Copy link

It looks like Microsoft renamed property upn to legacyUpn. Either fix it by changing component's property or maybe MS should change it back to upn?

Where did you find the information about this property name update?

@SharePickle
Copy link
Contributor

It looks like Microsoft renamed property upn to legacyUpn. Either fix it by changing component's property or maybe MS should change it back to upn?

Where did you find the information about this property name update?

I've debugged it and when I change upn to legacyUpn it works.

image
image

@muppanasashikumar
Copy link
Author

muppanasashikumar commented Jun 23, 2022

legacyUpn

It looks like Microsoft renamed property upn to legacyUpn. Either fix it by changing component's property or maybe MS should change it back to upn?

Where did you find the information about this property name update?

I've debugged it and when I change upn to legacyUpn it works.

image image

Could you please let me know from where did you find this file location?

@SharePickle
Copy link
Contributor

SharePickle commented Jun 23, 2022

Could you please let me know from where did you find this file location?

Here's the file https://res-1.cdn.office.net/files/sp-client/sp-webpart-shared_en-us_548b73a3d19b222579a2.js
Line number 4904 is where it renders the card on hover.
This file could be different for you tenant, just look for sp-webpart-shared js file.

Of course you can't edit MS's LivePersona file, you'd need to fix PnP library.

@divosuplente
Copy link

I have implemented the change in my own component and I can confirm that it works! thank you so much @SharePickle!

@muppanasashikumar
Copy link
Author

Could you please let me know from where did you find this file location?

Here's the file https://res-1.cdn.office.net/files/sp-client/sp-webpart-shared_en-us_548b73a3d19b222579a2.js Line number 4904 is where it renders the card on hover. This file could be different for you tenant, just look for sp-webpart-shared js file.

Of course you can't edit MS's LivePersona file, you'd need to fix PnP library.
Great man it worked for me. Thanks a lot appreciated. You are a saviour for me. @SharePickle

@debarunbanerjee2018
Copy link

Could you please let me know from where did you find this file location?

Here's the file https://res-1.cdn.office.net/files/sp-client/sp-webpart-shared_en-us_548b73a3d19b222579a2.js Line number 4904 is where it renders the card on hover. This file could be different for you tenant, just look for sp-webpart-shared js file.

Of course you can't edit MS's LivePersona file, you'd need to fix PnP library.

Many Many Thanks. Was struggling for past 2-3 days. Thank you so much mate. 🙏 Much love from India.

@joelfmrodrigues
Copy link
Collaborator

@SharePickle many thanks for providing a fix!
Just to confirm, is this the change that you implemented within the LivePersona component?
image

@SharePickle
Copy link
Contributor

@SharePickle many thanks for providing a fix! Just to confirm, is this the change that you implemented within the LivePersona component? image

Correct. I also provided a PR with the fix.

@joelfmrodrigues
Copy link
Collaborator

@SharePickle many thanks! will review now

@joelfmrodrigues
Copy link
Collaborator

The PR is now merged and the fix should be available shortly in the auto-published beta release. Thanks @SharePickle !
If someone has the chance to test the beta package that will be available shortly please let us know if everything is resolved.

@joelfmrodrigues
Copy link
Collaborator

Hey all, just providing a quick update - 3.8.1 released as hotfix to resolve this issue
@SharePickle I will revert your changes from dev and pull them from master - I have added your name to the changes in 3.8.1 so you will still appear as contributor

mikeschaefer pushed a commit to mikeschaefer/SPFxLivePersonaCard that referenced this issue Jul 5, 2022
Per PnP running into the same issue, pnp/sp-dev-fx-controls-react#1241, adding legacyUpn to createElement props
@ValerasNarbutas
Copy link
Contributor

joelfmrodrigues

good day, looks like this one does not work anymore.
and also i dont see legacyUpn property in LivePersona new version component.

@SharePickle
Copy link
Contributor

@ValerasNarbutas did Microsoft change it back to upn?
Because on my tenant it looks like this (both properties supported):
image

Maybe renaming legacyUpn back to upn will help, but for now on my environment LivePersona still works.

@ValerasNarbutas
Copy link
Contributor

@ValerasNarbutas did Microsoft change it back to upn? Because on my tenant it looks like this (both properties supported): image

Maybe renaming legacyUpn back to upn will help, but for now on my environment LivePersona still works.

I see, well i have multiple issues.

  1. When used pnp live persona component i did not get image in people coin but hover and popup worked.
  2. added a custom live persona card from @hugoabernier sample and now i get a picture in coin but hover not working.
    3 hover and popup is only starting to work if i hover first out of the box person coin. When some javascript library called "some guid"_LivePersonaCard_with)react.js loaded in background and its works both on PNP component, my custom one also.

So looks like something is still missing :(

@SharePickle
Copy link
Contributor

@ValerasNarbutas any updates? Are you experiencing this issue still? I had issues with person's profile pic because MS updated profile picture service, but it's all good now.

@ValerasNarbutas
Copy link
Contributor

@ValerasNarbutas any updates? Are you experiencing this issue still? I had issues with person's profile pic because MS updated profile picture service, but it's all good now.

hey @SharePickle looks like all good,
For me i am using @hugoabernier component and it works, but my colleague have no issue with MS persona component.

@joelfmrodrigues
Copy link
Collaborator

@ValerasNarbutas really sorry for the delay in replying back to you, I have been super busy with work in the last 2 months before end of year.
Based on your last reply, is this all working again for you? I assume MS must have reverted the breaking change if this is the case...

@ValerasNarbutas
Copy link
Contributor

have reverted the breaking change if t

yes, looks like it

@joelfmrodrigues
Copy link
Collaborator

@ValerasNarbutas many thanks for confirming

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants