Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Any interest in a Pagination Control and/or Carousel Control? #227

Closed
hugoabernier opened this issue Jan 23, 2019 · 4 comments
Closed

Any interest in a Pagination Control and/or Carousel Control? #227

hugoabernier opened this issue Jan 23, 2019 · 4 comments
Labels
area:new-control
Milestone
1.15.0

Comments

@hugoabernier
Copy link
Contributor

hugoabernier commented Jan 23, 2019 •
edited
Loading

Category

[ ] Enhancement

[ ] Bug

[X] Question

Question

A while ago, I created a pagination control for the Calendar Feed Web Part Sample, which was designed to mimic the out-of-the-box SharePoint Events web part.

I also created a carrusel control that allows you to scroll through items in a wide or narrow style, much like the out of the box SharePoint web parts.

Calendar Feed Wide

Calendar Feed Narrow

This layout is becoming more and more used throughout SharePoint, for example the Sites web part:

Sites -- Wide Layout

Sites -- Narrow

When I demoed the Calendar Feed web part during SPFx SIG call, I got a lot of feedback from attendees saying I should submit the control to the PnP controls.

The controls are already designed to allow any type of "items", not just events. You could insert document previews, etc.

You can see the existing code in the component's folder in the repo. It contains CarouselContainer, DateBox, EventCard, and Paging controls, but (unless it would be useful to anyone), I'm only proposing to create a CarouselContainer and Paging control.

I'd be happy to submit this, but I want to make sure I'm not wasting anyone's (including mine) time.

Is this something that would be useful for anyone?
@hugoabernier hugoabernier changed the title Any interest in a Pagination Control and/or Slider Control? Any interest in a Pagination Control and/or Carousel Control? Jan 23, 2019
@gautamdsheth
Copy link
Contributor

gautamdsheth commented Jan 25, 2019 •
edited
Loading

Yes, absolutely. Would love to see this implemented, especially the Pagination control. For pagination, would like to see couple of other options such as (Prev/Next) along with Page numbers something similar to React bootstrap pagination with the Fabric UI flavour !

@estruyf
Copy link
Member

estruyf commented Jan 25, 2019

This could indeed be a great addition to the project. Just for the extensibility of this control, I would make it so that the items which are rendered, are passed as React components to the control. That way, you can use it for whatever you want.

@siata13 siata13 mentioned this issue Jul 17, 2019
Merged
@estruyf
Copy link
Member

estruyf commented Jul 18, 2019

The new Carousel control has been merged and is now available to test out in the latest beta release. More information on how you can install a beta version can be found here: https://sharepoint.github.io/sp-dev-fx-controls-react/beta/

@estruyf estruyf added this to the 1.15.0 milestone Jul 18, 2019
@estruyf estruyf mentioned this issue Oct 14, 2019
Merged
@estruyf
Copy link
Member

estruyf commented Oct 14, 2019

Closing this issue as version 1.15.0 has just been released.

@estruyf estruyf closed this as completed Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:new-control
Projects
None yet
Milestone
1.15.0
Development

No branches or pull requests
4 participants
@estruyf @VesaJuvonen @gautamdsheth @hugoabernier