Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placeholder for Taxonomy Picker #464

Closed
rabwill opened this issue Jan 17, 2020 · 8 comments
Closed

Placeholder for Taxonomy Picker #464

rabwill opened this issue Jan 17, 2020 · 8 comments
Labels
type:enhancement New feature or enhancement of existing capability
Milestone

Comments

@rabwill
Copy link

rabwill commented Jan 17, 2020

Category

[x] Enhancement

[ ] Bug

[ ] Question

Version

7.82.1

A placeholder property for TaxonomyPicker , see image below

image

Thanks!
Rabia

@ghost
Copy link

ghost commented Jan 17, 2020

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Jan 17, 2020
@github-actions
Copy link

Thank you for submitting your first issue to this project.

@rabwill
Copy link
Author

rabwill commented Jan 19, 2020

Happy to pick this up , I am thinking of adding a new property placeHolder and passing it as inputProps (native input property) of the JSX element TermBasePicker, display only on no values (empty picker)

AJIXuMuK added a commit that referenced this issue Feb 20, 2020
@AJIXuMuK AJIXuMuK added type:enhancement New feature or enhancement of existing capability and removed Needs: Triage 🔍 labels Feb 20, 2020
@AJIXuMuK AJIXuMuK added this to the 1.17.0 milestone Feb 20, 2020
@AJIXuMuK
Copy link
Collaborator

Hi @rabwill,
Thank you for the idea! It was much easier to just implement than getting back and forth on GitHub :)
So, the placeholder property should be available in beta and in the next drop.

I've also included you as a contributor for the version as this is completely your idea and you provided the possible implementation description.

@rabwill
Copy link
Author

rabwill commented Feb 20, 2020

Thanks so much Alex ! You're a legend 😊

@RicoNL
Copy link
Contributor

RicoNL commented Feb 20, 2020

Would it be possible to implement the placeholder also on the PeoplePicker?

@AJIXuMuK
Copy link
Collaborator

Thank you @rabwill for kind words :)

@RicoNL - I'm thinking of expanding it to all pickers we have.

@AJIXuMuK
Copy link
Collaborator

Done for ListItemPicker and PeoplePicker.
For the ListPicker I deprecated placeHolder and added placeholder so all the pickers have the same property.
All the changes are available in beta and will be included in the next drop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or enhancement of existing capability
Projects
None yet
Development

No branches or pull requests

4 participants