Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FilePicker: default tab when opened shows hidden RecentTab #477

Closed
1 of 3 tasks
mpowney opened this issue Feb 6, 2020 · 6 comments
Closed
1 of 3 tasks

FilePicker: default tab when opened shows hidden RecentTab #477

mpowney opened this issue Feb 6, 2020 · 6 comments
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:bug
Milestone

Comments

@mpowney
Copy link

mpowney commented Feb 6, 2020

Category

  • Enhancement
  • Bug
  • Question

Version

Please specify what version of the library you are using: [ 1.16.0 ]

Expected Behavior

When the Recent files tab is hidden via the hideRecentTab prop, the first non-hidden tab should be shown when the FilePicker is initiated, instead of the "Recent" tab.

If the following props were specified:

hideRecentTab={true}
hideWebSearchTab={true}
hideOrganisationalAssetTab={true}
hideOneDriveTab={true}
hideSiteFilesTab={true}
hideLinkUploadTab={true}

... the only available tab is the LocalUploadTab, therefore when the FilePicker is initiated the LocalUploadTab should be displayed (not the RecentTab).

Observed Behavior

When tabs are hidden in the FilePicker control, e.g. any of the following props are set to true:

hideRecentTab={true}
hideWebSearchTab={true}
hideOrganisationalAssetTab={true}
hideOneDriveTab={true}
hideSiteFilesTab={true}
hideLinkUploadTab={true}

The default tab shown when the FilePicker is displayed is the RecentTab. The user must then navigate to the tab(s) that are not hidden.

Steps to Reproduce

  1. Create a React component that renders the FilePicker control
  2. Set the the props of the FilePicker control as follows:
hideRecentTab={true}
hideWebSearchTab={true}
hideOrganisationalAssetTab={true}
hideOneDriveTab={true}
hideSiteFilesTab={true}
hideLinkUploadTab={true}
  1. Render the React component in a web browser and initiate the FilePicker control UI
  2. Observe the default tab displayed is the RecentTab, even though that tab should be hidden
@ghost
Copy link

ghost commented Feb 6, 2020

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Feb 6, 2020
@github-actions
Copy link

github-actions bot commented Feb 6, 2020

Thank you for submitting your first issue to this project.

@AJIXuMuK AJIXuMuK added status:tracked Triaged and are being investigated further type:bug and removed Needs: Triage 🔍 labels Feb 12, 2020
@AJIXuMuK
Copy link
Collaborator

Thank you @mpowney for reporting this!
We'll be working on it!

@Greg-Hitchon
Copy link

Also experiencing this issue. Any timeline on getting a fix?

@saurav2107
Copy link

I am also facing the same issue, any update on this issue?

@AJIXuMuK AJIXuMuK added status:fixed-next-drop Issue will be fixed in upcoming release. and removed status:tracked Triaged and are being investigated further labels Jul 4, 2020
@AJIXuMuK AJIXuMuK added this to the 1.20.0 milestone Jul 4, 2020
AJIXuMuK added a commit that referenced this issue Jul 4, 2020
@AJIXuMuK
Copy link
Collaborator

AJIXuMuK commented Jul 4, 2020

Hi all,
The issue has been fixed and will be included in the next release.
In a meanwhile you can test the functionality in beta version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:bug
Projects
None yet
Development

No branches or pull requests

4 participants