Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ComboBoxListItemPicker fetching only 100 items~! It should fetch all items from a list? #569

Closed
ashishasolkar opened this issue May 26, 2020 · 2 comments
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:bug
Milestone

Comments

@ashishasolkar
Copy link

Category

[X] Enhancement

[ ] Bug

[ ] Question

Version

Please specify what version of the library you are using: [ ]
"@pnp/spfx-controls-react": "1.18.0"
"@microsoft/sp-core-library": "1.10.0",
"@microsoft/sp-lodash-subset": "1.10.0",
"@microsoft/sp-office-ui-fabric-core": "1.10.0",
"@microsoft/sp-property-pane": "1.10.0",
"@microsoft/sp-webpart-base": "1.10.0",
"@pnp/sp": "^2.0.4",

Expected / Desired Behavior / Question

Currently ComboBoxListItemPicker control can fetch first 100 items from list. Expected behavior is to fetch all the items from list for specified column.

Observed Behavior

ComboBoxListItemPicker can fetch only first 100 items and not all items from list.

Steps to Reproduce

  1. Create react based spfx webpart.
  2. Add ComboBoxListItemPicker control as described in article:
    https://pnp.github.io/sp-dev-fx-controls-react/controls/ComboBoxListItemPicker/
    <ComboBoxListItemPicker listId='da8daf15-d84f-4ab1-9800-7568f82fed3f' columnInternalName='Title' keyColumnInternalName='Id' filter="Title eq 'SPFx'" onSelectedItem={this.onSelectedItem} webUrl={this.context.pageContext.web.absoluteUrl} spHttpClient={this.context.spHttpClient} />
    For next steps make sure you are at-least having office 365 dev subscription.
  3. Create a custom/generic list - Countries.
  4. Enter in "Quick Edit" mode of list and enter values from below mentioned link in "Title" column:
    https://alphabetizer.flap.tv/lists/list-of-all-world-countries.php
  5. Map Countries list and Title column with ComboBoxListItemPicker.
  6. Run the project. It will fetch only first 100 items from list and not all the items.

Thanks!

@ghost
Copy link

ghost commented May 26, 2020

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label May 26, 2020
@AJIXuMuK AJIXuMuK added status:fixed-next-drop Issue will be fixed in upcoming release. type:bug and removed Needs: Triage 🔍 labels Jun 21, 2020
@AJIXuMuK AJIXuMuK added this to the 1.20.0 milestone Jun 21, 2020
@AJIXuMuK
Copy link
Collaborator

Hi @ashishasolkar!
Thank you for reporting this bug!
I've added itemLimit property to the component. You can use it to fetch more that 100 items (which is default).
Please, test the functionality in beta version.
It will also be available in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:bug
Projects
None yet
Development

No branches or pull requests

2 participants