Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PeoplePicker The error message not showing #590

Closed
evdma opened this issue Jun 20, 2020 · 5 comments
Closed

PeoplePicker The error message not showing #590

evdma opened this issue Jun 20, 2020 · 5 comments
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:bug
Milestone

Comments

@evdma
Copy link

evdma commented Jun 20, 2020

The error message still not showing

Originally posted by @evdma in #420 (comment)

@ghost
Copy link

ghost commented Jun 20, 2020

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Jun 20, 2020
@AJIXuMuK
Copy link
Collaborator

Hi @evdma!
Thank you for reporting the issue.

The error message is showing when selected people are removed from the component.
It does not show up right after the component is rendered if there are no initially selected users.

I do believe that this is more or less correct behavior - I don't think it's a good idea to show error message right away before any interaction with the control (or at least form where it is located).

But I also believe that we could add some way to notify control to display the message from outside (for example, when Save button is clicked on your form).

Will such approach work for you?

@AJIXuMuK AJIXuMuK added status:tracked Triaged and are being investigated further and removed Needs: Triage 🔍 labels Jun 21, 2020
@evdma
Copy link
Author

evdma commented Jun 24, 2020

Hi @AJIXuMuK !
It would be useful to add a message display when a button is clicked.
This is exactly the behavior I was trying to achieve.

@AJIXuMuK AJIXuMuK added status:fixed-next-drop Issue will be fixed in upcoming release. type:bug and removed status:tracked Triaged and are being investigated further labels Jul 4, 2020
@AJIXuMuK AJIXuMuK added this to the 1.20.0 milestone Jul 4, 2020
@AJIXuMuK
Copy link
Collaborator

AJIXuMuK commented Jul 4, 2020

Hi @evdma!
I've added a new prop - showRequiredError.
You can set this prop to true to initiate flow to display required error message, if needed.
The fix will be included in the next release.

In a meanwhile you can test the functionality in beta version

@evdma
Copy link
Author

evdma commented Jul 7, 2020

@AJIXuMuK cool! Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:bug
Projects
None yet
Development

No branches or pull requests

2 participants