Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Caoursel] Changing pages doesn't work #609

Closed
siata13 opened this issue Jul 10, 2020 · 2 comments
Closed

[Caoursel] Changing pages doesn't work #609

siata13 opened this issue Jul 10, 2020 · 2 comments
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:bug
Milestone
1.20.0

Comments

@siata13
Copy link
Contributor

siata13 commented Jul 10, 2020

Category

[ ] Enhancement

[x] Bug

[ ] Question

Version

Please specify what version of the library you are using: [1.20.0 dev]

Expected / Desired Behavior / Question

Carousel paging doesn't work.

Observed Behavior

Carusel control doesn't move to next page in case triggerPageEvent is not set to true and moveNext/movePrevious handlers are undefined.

Steps to Reproduce

Initialize Carousel control without: onMoveNextClicked, onMovePrevClicked, triggerPageEvent properties. Control will not switch pages as it tries to execute undefined handlers (onMovePrevClicked, onMoveNextClicked).
@ghost
Copy link

ghost commented Jul 10, 2020

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Jul 10, 2020
@siata13 siata13 mentioned this issue Jul 10, 2020
Merged
AJIXuMuK added a commit that referenced this issue Jul 10, 2020
@AJIXuMuK
Merge pull request #610 from siata13/dev
a24e895 
#609 Fix invalid invocation of Carousel handlers.
@AJIXuMuK AJIXuMuK added status:fixed-next-drop Issue will be fixed in upcoming release. type:bug and removed Needs: Triage 🔍 labels Jul 10, 2020
@AJIXuMuK AJIXuMuK added this to the 1.20.0 milestone Jul 10, 2020
@AJIXuMuK
Copy link
Collaborator

Thank you @siata13 for reporting and fixing the bug!

@estruyf estruyf mentioned this issue Sep 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:bug
Projects
None yet
Milestone
1.20.0
Development

No branches or pull requests
2 participants
@siata13 @AJIXuMuK