Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FolderPicker control not working #614

Closed
jorgesoprani opened this issue Jul 14, 2020 · 3 comments
Closed

FolderPicker control not working #614

jorgesoprani opened this issue Jul 14, 2020 · 3 comments
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:bug
Milestone

Comments

@jorgesoprani
Copy link

Category

[ ] Enhancement

[X] Bug

[ ] Question

Version

Please specify what version of the library you are using: [1.19.0]

Expected / Desired Behavior / Question

I'm trying to use the FolderPicker control as it's documented, but the imports are not working.

Observed Behavior

I'm trying to import the component as it's documentend:

import { FolderPicker, IFolder } from "@pnp/spfx-controls-react/lib/FolderPicker";

But with that i get an error: '...has no exported member 'FolderPicker'" and "... has no exported member 'IFolder'"

Steps to Reproduce

All I did was installing the package in a recently created SPFX Reac app and trying to import the controls.

@ghost
Copy link

ghost commented Jul 14, 2020

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Jul 14, 2020
@AJIXuMuK
Copy link
Collaborator

AJIXuMuK commented Aug 6, 2020

Hi @jorgesoprani!
Thank you for reporting this!
Yes, it's a bug.

We will take care of it.

In a meantime, you can use the imports like that:

import FolderPicker from '@pnp/spfx-controls-react/lib/controls/folderPicker/FolderPicker';
import { IFolder } from '@pnp/spfx-controls-react/lib/services/IFolderExplorerService';

@AJIXuMuK AJIXuMuK added status:tracked Triaged and are being investigated further type:bug and removed Needs: Triage 🔍 labels Aug 6, 2020
AJIXuMuK added a commit that referenced this issue Aug 25, 2020
@AJIXuMuK AJIXuMuK added this to the 1.20.0 milestone Aug 25, 2020
@AJIXuMuK AJIXuMuK added status:fixed-next-drop Issue will be fixed in upcoming release. and removed status:tracked Triaged and are being investigated further labels Aug 25, 2020
@AJIXuMuK
Copy link
Collaborator

Starting v 1.20.0 you'll be able to use:

import FolderPicker from '@pnp/spfx-controls-react/lib/controls/folderPicker/FolderPicker';
import { IFolder } from '@pnp/spfx-controls-react/lib/FolderPicker';

And later, in v2, it will be fixed completely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:bug
Projects
None yet
Development

No branches or pull requests

2 participants