Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ListView Sort Fires Selection #621

Closed
tom-daly opened this issue Jul 25, 2020 · 3 comments
Closed

ListView Sort Fires Selection #621

tom-daly opened this issue Jul 25, 2020 · 3 comments
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:bug
Milestone

Comments

@tom-daly
Copy link
Contributor

Category

[ ] Enhancement

[X ] Bug

[ ] Question

Version

Please specify what version of the library you are using: [
"@pnp/spfx-controls-react": "1.19.0",
]

Expected / Desired Behavior / Question

Why does the sort event fire the selection event? Is there any way to avoid this or detect that it was a sort event or a select event?

Observed Behavior

The sort event is firing the selection event which is problematic for my case.

Steps to Reproduce

background: I have code that opens a new window to an app passing some parameters.

  • I first click a row, which fires the selection event.
  • then i click sort.
  • I can see it fires the selection event with no items and then fires it again with the selected item.
  • Each time I sort it also launches this new window with the last file clicked.
@ghost
Copy link

ghost commented Jul 25, 2020

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Jul 25, 2020
AJIXuMuK added a commit that referenced this issue Aug 15, 2020
@AJIXuMuK AJIXuMuK added status:fixed-next-drop Issue will be fixed in upcoming release. type:bug and removed Needs: Triage 🔍 labels Aug 15, 2020
@AJIXuMuK AJIXuMuK added this to the 1.20.0 milestone Aug 15, 2020
@AJIXuMuK
Copy link
Collaborator

Hi @tom-daly!
Thank you for reporting the issue.

It has been fixed and will be included in the next release.

In a meanwhile you can test the functionality in beta version.

@tom-daly
Copy link
Contributor Author

thank you for your efforts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:bug
Projects
None yet
Development

No branches or pull requests

2 participants