FilePicker: Site Tab does not load document if we access SharePoint site in different language than default language of the site

[kalpeshvaghela90]

Category

[ ] Enhancement

[X ] Bug

[ ] Question

Version

Please specify what version of the library you are using: [ 1.16.0 ]

Expected

FilePicker - Site Tab should work doesn't matter in which language we are accessing site.

Observed Behavior

If SharePoint site's default language is English, and if you access site in any other language then Site tab will show list of document library but if we click on any library then it doesn't get document from that document library (specially in case of default library i.e. Site Pages, Site Assets, Document Library) if document library title is multi lingual.

Steps to Reproduce

1. Create one site collection in English language
2. Deploy web part/extension which does have File picker used
3. Access site in different language than default language English
4. Open File Picker and click on Site Tab and select default library i.e. Site Assets/Documents/Site Pages
5. It will not show any documents

Submission Guidelines

I went through code and found that document library are being accessed using GetByTitle method.

It should not use List Title in order to get query in document library but it should use either list server relative URL or List Id

Thanks!

[ghost]

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

[AJIXuMuK]

Thank you @kalpeshvaghela90 for reporting that issue!

[AJIXuMuK]

Hi @kalpeshvaghela90,

I have implemented the fix. Could you please test it in beta version?

[nbelyh]

@AJIXuMuK Now it seems that the folder browser stopped working altogether when navigating from the "Sites" view 😄 (works only on the root site). It throws an exception here (404, file not found), on any locale, /sites/AnySite/ url:

sp-dev-fx-controls-react/src/services/FileBrowserService.ts

Lines 30 to 32 in 56d7e01

	try {
	let restApi = `${this.context.pageContext.web.absoluteUrl}/_api/web/GetList('${listUrl}')/RenderListDataAsStream`;

The thing is, it tries to do this: getList('/Shared%20Documents')
When it actually it probably should do this: getList('/site/AnySite/Shared%20Documents')

Looks like getList() expects full relative url, not a partial one.

I guess the link line above should be changed like this maybe?

      let restApi = `${this.context.pageContext.web.absoluteUrl}/_api/web/GetList('${this.context.pageContext.web.serverRelativeUrl}/${listUrl}')/RenderListDataAsStream`;

[AJIXuMuK]

Thank you @nbelyh! Good catch!

Now it should be fixed.