Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FilePicker - select folder for upload #746

Closed
nbelyh opened this issue Nov 26, 2020 · 8 comments
Closed

FilePicker - select folder for upload #746

nbelyh opened this issue Nov 26, 2020 · 8 comments
Labels
type:enhancement New feature or enhancement of existing capability
Milestone

Comments

@nbelyh
Copy link
Contributor

nbelyh commented Nov 26, 2020

Category

[x] Enhancement

[ ] Bug

[ ] Question

Version

Please specify what version of the library you are using: [2.1.0]

Desired Behavior

Would be really great if the FilePicker allowed you to select a place where to upload the file (target document library / target folder). Something like this one the "Upload" tab (it's completely blank now):

image

Alternative

Alternatively, it would be good enough to have a callback to render custom content for the upload tab ("renderUpload" or something like this). So that user can equip the file being uploaded with required additional information. This can be not necessarily the target folder only; it can also be some required properties for the target document library for example.

@ghost
Copy link

ghost commented Nov 26, 2020

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Nov 26, 2020
@AJIXuMuK
Copy link
Collaborator

Hi @nbelyh!
It's a good idea! Thank you for sharing!

@AJIXuMuK AJIXuMuK added help wanted type:enhancement New feature or enhancement of existing capability and removed Needs: Triage 🔍 labels Nov 28, 2020
@nbelyh
Copy link
Contributor Author

nbelyh commented Nov 28, 2020

@AJIXuMuK Do you think it would make more sense to add folder selector or a generic solution that would allow any fields (but these are to be implemented by user)? I think the second could be much easier to implement and more generic. The first one will provide extra value immediately though. But could be implemented as a test/example.

@AJIXuMuK
Copy link
Collaborator

@nbelyh - I would do the second.

And yes, it would be awesome to include example in the web part included in the project.

@nbelyh
Copy link
Contributor Author

nbelyh commented Nov 29, 2020

@AJIXuMuK Created related PR. Please kindly check when you have time 😃

@AJIXuMuK
Copy link
Collaborator

AJIXuMuK commented Dec 2, 2020

Thank you @nbelyh - merged!

@nbelyh
Copy link
Contributor Author

nbelyh commented Dec 3, 2020

Have not noticed missing escape for the "|" symbol, the documentation comes out wrong - created a PR to fix. Sorry 😅

@AJIXuMuK
Copy link
Collaborator

AJIXuMuK commented Dec 3, 2020

Thank you @nbelyh

@AJIXuMuK AJIXuMuK closed this as completed Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or enhancement of existing capability
Projects
None yet
Development

No branches or pull requests

2 participants