Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docs for new file picker custom renderers ("|" not escaped) #756

Merged
merged 1 commit into from
Dec 8, 2020
Merged

Fix docs for new file picker custom renderers ("|" not escaped) #756

merged 1 commit into from
Dec 8, 2020

Conversation

nbelyh
Copy link
Contributor

@nbelyh nbelyh commented Dec 3, 2020

…ption)

Q A
Bug fix? [ ]
New feature? [ ]
New sample? [ ]
Related issues? documentation for #746

What's in this Pull Request?

The documentation fix (descriptions for the added renderCustomUploadTabContent and renderCustomLinkTabContent are broken). Vertical line was not escaped.

@nbelyh nbelyh changed the title Fix markdown format for the file picker custom pickers (broken descri… Fix docs for new file picker custom renderers ("|" not escaped) Dec 3, 2020
@AJIXuMuK AJIXuMuK merged commit f834cf0 into pnp:dev Dec 8, 2020
@AJIXuMuK AJIXuMuK modified the milestones: 1.21.1, 2.3.0 Dec 8, 2020
@AJIXuMuK
Copy link
Collaborator

AJIXuMuK commented Dec 8, 2020

Thank you @nbelyh for the fix!

@nbelyh nbelyh deleted the fix_docs_file_picker_custom_renderers branch December 9, 2020 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nbelyh @AJIXuMuK