Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add locale pt-br. I can help with translation. #857

Closed
joaoworkhub opened this issue Mar 31, 2021 · 5 comments
Closed

Add locale pt-br. I can help with translation. #857

joaoworkhub opened this issue Mar 31, 2021 · 5 comments
Labels
status:fixed-next-drop Issue will be fixed in upcoming release.

Comments

@joaoworkhub
Copy link

Thank you for reporting an issue, suggesting an enhancement, or asking a question. We appreciate your feedback - to help the team understand your
needs please complete the below template to ensure we have the details to help. Thanks!

Please check out the documentation to see if your question is already addressed there. This will help us ensure our documentation is up to date.

Category

[X ] Enhancement

[ ] Bug

[ ] Question

Version

Please specify what version of the library you are using: [ 2.0.0 ]

If you are not using the latest release, please update and see if the issue is resolved before submitting an issue.

Expected / Desired Behavior / Question

If you are reporting an issue please describe the expected behavior. If you are suggesting an enhancement please
describe thoroughly the enhancement, how it can be achieved, and expected benefit. If you are asking a question, ask away!

Observed Behavior

If you are reporting an issue please describe the behavior you expected to occur when performing the action. If you are making a
suggestion or asking a question delete this section.

Steps to Reproduce

If you are reporting an issue please describe the steps to reproduce the bug in sufficient detail to allow testing. If you are making
a suggestion or asking a question delete this section.

Submission Guidelines

Delete this section after reading

  • All suggestions, questions and issues are welcome, please let us know what's on your mind.
  • Remember to include sufficient details and context.
  • If you have multiple suggestions, questions, or bugs please submit them in separate issues so we can track resolution.

Thanks!

@ghost
Copy link

ghost commented Mar 31, 2021

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@joelfmrodrigues
Copy link
Collaborator

@joaoworkhub sounds like a great idea. Would you be able to submit a PR with the changes?

@kunj-sangani
Copy link
Contributor

@joelfmrodrigues and @joaoworkhub I have created a PR for the same

I have taken help from google translate so can you please verify once :)

kunj-sangani added a commit to kunj-sangani/sp-dev-fx-controls-react that referenced this issue Apr 6, 2021
kunj-sangani added a commit to kunj-sangani/sp-dev-fx-controls-react that referenced this issue Apr 6, 2021
kunj-sangani added a commit to kunj-sangani/sp-dev-fx-controls-react that referenced this issue Apr 6, 2021
joelfmrodrigues added a commit that referenced this issue Apr 11, 2021
@joelfmrodrigues
Copy link
Collaborator

@joaoworkhub this was just added to the dev-v2 branch and will be included in the next release.
If you have the chance, it would be great if you could double-check the file and submit a PR with any improvements:
https://github.com/pnp/sp-dev-fx-controls-react/blob/v2-dev/src/loc/pt-br.ts

Thanks for the suggestion.

@joelfmrodrigues joelfmrodrigues added status:fixed-next-drop Issue will be fixed in upcoming release. and removed Good First Issue 🏆 help wanted labels Apr 11, 2021
@joelfmrodrigues
Copy link
Collaborator

@joaoworkhub Closing this item as it was included on the latest release.
Many thanks for the suggestion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:fixed-next-drop Issue will be fixed in upcoming release.
Projects
None yet
Development

No branches or pull requests

3 participants