Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#857 Added locale pt-br #865

Merged
merged 3 commits into from
Apr 11, 2021
Merged

#857 Added locale pt-br #865

merged 3 commits into from
Apr 11, 2021

Conversation

kunj-sangani
Copy link
Contributor

Q A
Bug fix? [ X]
Related issues? fixes #857

What's in this Pull Request?

Please describe the changes in this PR. Sample description or details around bugs which are being fixed.

This will add locale for pt-br
Added a file named pt-br.ts inside loc folder

@kunj-sangani
Copy link
Contributor Author

@joelfmrodrigues
I hope this helps :)

src/loc/pt-br.ts Outdated Show resolved Hide resolved
src/loc/pt-br.ts Outdated Show resolved Hide resolved
@kunj-sangani
Copy link
Contributor Author

Hi @aaclage ,

Update as mentioned can you please verify again
Sorry it took a long time :)

src/loc/pt-br.ts Outdated Show resolved Hide resolved
@joelfmrodrigues
Copy link
Collaborator

@kunj-sangani many thanks for the PR
@aaclage thanks for reviewing it

There are some little things where I am not 100% sure if they are correct for pt-br, but will merge as is and will try to get a colleague from Brasil to double check :)

@joelfmrodrigues joelfmrodrigues merged commit 6bd3482 into pnp:v2-dev Apr 11, 2021
@joelfmrodrigues
Copy link
Collaborator

@kunj-sangani forgot to mention, but feel free to submit a PR also to dev branch if you get the chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants