-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SPFx PnP Controls depends on MGT #918
Comments
Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible. |
I think this issue was fixed with "@microsoft/mgt": "^2.2.0". |
I'll check that later. We've already have v2.2 in beta. |
@siata13 just to double-check if this is not a scenario similar to what I experienced this week at work, are you using the PnP controls package directly in your web part solution, or via a SPFx library component solution? |
I was able to repro it on beta version as well. But only if you use mat-dependent control ( I will check what's the best approach here. Maybe the best thing is to remove mgt dependency at all. |
@joelfmrodrigues I use it in web part solutions. But I believe that moving control relying on MGT to separate library would make it much easier. Thanks a lot for checking! |
@siata13 please check why it's happening. |
@AJIXuMuK I have found the problematic part of the code which wasn't related to pnp controls as I initially thought. Thanks for your time and support! |
Just pushed some changes originally done by @joaojmendes on a PR that should fix this issue by using mgt-spfx. Please note this is relevant for the MyTeams control. For anything else, use direct imports as suggested by @AJIXuMuK |
Category
[x] Enhancement
[x] Bug
[ ] Question
Version
PnP controls in version 3.1
Observed Behavior
PnP Controls package has a dependency on @microsoft/mgt (Graph Toolkit) which causes problems in case 2 web parts using controls are loaded on the page:
Expected / Desired Behavior / Question
The solution could be to switch to mgt-spfx (https://www.npmjs.com/package/@microsoft/mgt-spfx), but it brings additional problems to always install the latest version of the solution of relaying on PnP controls along with mgt-spfx.sppkg to provide all the functionalities.
Could the controls relaying on mgt be moved to separate project??
Thanks!
The text was updated successfully, but these errors were encountered: