[TaxonomyPicker] errorMessage label not being removed

[umaknow-jeanluc]

Category

[ ] Enhancement

[x] Bug

[ ] Question

Version

Please specify what version of the library you are using: [latest]

Expected / Desired Behavior / Question

When using the errorMessage prop and reverting it to an empty string, it should remove the previous errorMessage

Observed Behavior

When clearing the errorMessage prop from the component, the previous errorMessage is not cleared. The componentWillReceiveProps method escapes the assignation of the new errorMessage only when there is a value.

TaxonomyPicker

public componentWillReceiveProps(nextProps: ITaxonomyPickerProps) {
    let newState: ITaxonomyPickerState | undefined;
    // Check if the initial values objects are not equal, if that is the case, data can be refreshed
    if (!isEqual(this.props.initialValues, nextProps.initialValues)) {
      newState = {
        activeNodes: nextProps.initialValues || []
      };
    }

    if (nextProps.errorMessage) {
      if (!newState) {
        newState = {};
      }

      newState.errorMessage = nextProps.errorMessage;
    }

    if (newState) {
      this.setState(newState);
    }
  }

Steps to Reproduce

1. Create a component with the TaxonomyPicker
2. Create a state with an errorMessage variable containing a non-empty random string
3. Assign the errorMessage prop of the TaxonomyPicker with the state value previously assigned
4. Create a button with an onClick that setState of the errorMessage with an empty string
5. Notice that the errorMessage from the TaxonomyPicker is not cleared

Fix suggestion :
if (nextProps.errorMessage !== this.props.errorMessage) at line 93

Thanks!

[ghost]

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

[AJIXuMuK]

Thank you @umaknow-jeanluc for reporting and fixing the issue.
The fix will be included in the next release.