Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TaxonomyPicker): errorMessage not cleared when set to empty value #1006

Merged

Conversation

umaknow-jeanluc
Copy link
Contributor

Q A
Bug fix? [x]
New feature? [ ]
New sample? [ ]
Related issues? fixes #953

What's in this Pull Request?

This PR fixes the TaxonomyPicker to remove the errorMessage label when the errorMessage props is cleared (empty string).
Also updated the ControlTest component to reflect that change.

image
image

@AJIXuMuK AJIXuMuK merged commit 767a1c4 into pnp:dev Sep 2, 2021
@AJIXuMuK
Copy link
Collaborator

AJIXuMuK commented Sep 2, 2021

Thank you @umaknow-jeanluc for the PR.
It has been merged and will be included in the next release.

@AJIXuMuK AJIXuMuK added this to the 3.4.0 milestone Sep 2, 2021
@umaknow-jeanluc umaknow-jeanluc deleted the fix/taxonomypicker-errorMessage-clear branch September 2, 2021 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants