Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ PeoplePicker ] Default selected items for groups #958

Closed
a1exymoroz opened this issue Jul 13, 2021 · 2 comments
Closed

[ PeoplePicker ] Default selected items for groups #958

a1exymoroz opened this issue Jul 13, 2021 · 2 comments
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:bug

Comments

@a1exymoroz
Copy link
Contributor

Category

[x] Bug

[x] Question

Version

Please specify what version of the library you are using: [ "@pnp/spfx-controls-react": "^3.2.1" ]

Question

Why doesn't PeoplePicker have selected items for different types?
PeoplePicker has only defaultSelectedUsers for users. But if we use different types ([PrincipalType.SecurityGroup, PrincipalType.User, PrincipalType.SharePointGroup]), I'll have problem.

Observed Behavior

If we can use different types, we have to select different types.

Steps to Reproduce

  1. Set different principalTypes
    principalTypes={[PrincipalType.SecurityGroup, PrincipalType.User, PrincipalType.SharePointGroup]}
  2. Set different selected items
    defaultSelectedUsers={[User, Sharepoint Group, Azure AD group]}
  3. If we use defaultSelectedUsers, we need emails. But Sharepoint group doesn't have a email.
    If I use texts for defaultSelectedUsers, Azure AD group won't select

Thanks!

@ghost
Copy link

ghost commented Jul 13, 2021

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Jul 13, 2021
a1exymoroz pushed a commit to a1exymoroz/sp-dev-fx-controls-react that referenced this issue Jul 19, 2021
a1exymoroz pushed a commit to a1exymoroz/sp-dev-fx-controls-react that referenced this issue Jul 19, 2021
a1exymoroz pushed a commit to a1exymoroz/sp-dev-fx-controls-react that referenced this issue Jul 29, 2021
a1exymoroz added a commit to a1exymoroz/sp-dev-fx-controls-react that referenced this issue Jul 29, 2021
AJIXuMuK added a commit that referenced this issue Aug 6, 2021
…LT-SELECTED-ITEMS

feat/#958 Add selected items for groups
@AJIXuMuK AJIXuMuK added status:fixed-next-drop Issue will be fixed in upcoming release. type:bug and removed Needs: Triage 🔍 labels Aug 6, 2021
@AJIXuMuK
Copy link
Collaborator

AJIXuMuK commented Aug 6, 2021

Thanks @a1exymoroz for submitting both issue and fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:bug
Projects
None yet
Development

No branches or pull requests

2 participants