Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added filter for Microsoft 365 Group to PeoplePicker #1027

Merged
merged 7 commits into from
Nov 18, 2021

Conversation

andreasomayrat
Copy link
Contributor

Q A
Bug fix? [ ]
New feature? [x]
New sample? [ ]
Related issues?

What's in this Pull Request?

Added a filter for Microsoft 365 Group in PeoplePicker

@AJIXuMuK
Copy link
Collaborator

AJIXuMuK commented Oct 2, 2021

Hi @andreasomayrat - thank you for the PR!

Could you please edit a code a bit to use string instead of Guid for the group id?

@andreasomayrat
Copy link
Contributor Author

Hi @AJIXuMuK
I have now updated the code to use string instead of Guid

@joelfmrodrigues joelfmrodrigues changed the base branch from master to dev November 9, 2021 17:25
@joelfmrodrigues
Copy link
Collaborator

Changed target branch to dev

@joelfmrodrigues
Copy link
Collaborator

@andreasomayrat updating documentation to include Directory.Read.All permissions as without it the API call returns users with null properties

@joelfmrodrigues joelfmrodrigues merged commit fa7cafb into pnp:dev Nov 18, 2021
@joelfmrodrigues
Copy link
Collaborator

@andreasomayrat many thanks for the improvements, this has now been merged (I have made only very small adjustments). Will be available in the next release and in the beta version in a few minutes

@joelfmrodrigues joelfmrodrigues added this to the 3.5.0 milestone Nov 18, 2021
@estruyf estruyf mentioned this pull request Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants