Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed single selection to multiple selection for Recent, OneDrive and Site Files tabs in FilePicker component #1047

Merged

Conversation

MonalisaBaltatescu
Copy link

@MonalisaBaltatescu MonalisaBaltatescu commented Oct 25, 2021

…s for FilePicker component

Q A
Bug fix? [ ]
New feature? [x]
New sample? [ ]
Related issues? fixes #725

What's in this Pull Request?

The current version of the FilePicker doesn't support multiple selections for files.
I have changed the selection mode to multiple for Recent, OneDrive and Site Files tabs.
The folders cannot be selected but could be opened and multiple selections apply inside.

@joelfmrodrigues joelfmrodrigues changed the base branch from master to dev October 31, 2021 23:45
@MonalisaBaltatescu
Copy link
Author

@joelfmrodrigues could this PR be closed and merged now that the target branch is master?

@joelfmrodrigues
Copy link
Collaborator

@MonalisaBaltatescu just tested the PR and it's great! Thank you for the improvements.
While testing it, I found just an error on the console when selecting folders (tested using the Site option):

  1. Select a folder from a document library in a SharePoint site
    image

  2. The following error is logged:
    image

  3. This is the code generating the error (line 459):
    image

Is this line required to handle folders? I tried to comment it and it seems to behave the same, although it could be because of the error not allowing it to behave the same way you expected.

Other than that, all looks good and ready to go ☺️

@joelfmrodrigues
Copy link
Collaborator

Hi @MonalisaBaltatescu

just checking if you would be able to advise on the above?

@MonalisaBaltatescu
Copy link
Author

Hi, I’m working on it. Just need more time ☺️

@estruyf estruyf deleted the branch pnp:dev December 3, 2021 08:27
@estruyf estruyf closed this Dec 3, 2021
@estruyf
Copy link
Member

estruyf commented Dec 3, 2021

@MonalisaBaltatescu I have no idea why the PR got closed. Going to re-open it.

@estruyf estruyf reopened this Dec 3, 2021
@joelfmrodrigues
Copy link
Collaborator

@MonalisaBaltatescu sorry to chase you again with this, but just wondering if you need some help?

Fixed folder selection on Recents tab -> no folder selection allowed
@MonalisaBaltatescu
Copy link
Author

@joelfmrodrigues I am sorry for the delay, didn't have the time lately. Please check now and let me know if there are any other issues

@joelfmrodrigues joelfmrodrigues merged commit f2383f6 into pnp:dev Feb 7, 2022
@joelfmrodrigues
Copy link
Collaborator

@MonalisaBaltatescu many thanks for the update and absolutely no need to apologise as these are voluntary contributions - I am also having issues finding the time to contribute myself

I have tested it and all seems to be working fine, many thanks

@joelfmrodrigues joelfmrodrigues added this to the 3.6.0 milestone Feb 7, 2022
@AJIXuMuK AJIXuMuK mentioned this pull request Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PNP SPFx FilePicker multi select
3 participants