Added feature to add action button to terms in ModernTaxonomyPicker #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrikhellgren
force-pushed
the
modern-taxonomy-picker-2
branch
from
e60c517
to
9033c54
Compare
|
Hi @estruyf, What happened to this PR, why was it closed without being merged first? |
|
@patrikhellgren I have no idea why the PR got closed. Going to re-open it. |
|
Thank you @patrikhellgren for these updates! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this Pull Request?
Added a feature to ModernTaxonomyPicker to add a custom action button to each term in the term set and the term set itself.
This also comes with the added bonus of better handling of keyboard navigation.
Added properties isLightDismiss and isBlocking that will be used for the panel.
Refactored TaxonomyTree into a separate component that could be used separately to just display a term set with action buttons for e.g. an admin UI.
Here is an example of what it could look like with a context menu for adding and deleting terms in the control: