Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PeoplePicker docs - fix broken import statement #1248

Closed
wants to merge 1 commit into from

Conversation

PeterWCox
Copy link

@PeterWCox PeterWCox commented Jun 26, 2022

Partial fix to the issue described here by updating documentation for import statement - see #1235

Q A
Bug fix? [X ]
New feature? [ ]
New sample? [ ]
Related issues? fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?

As above

Partial fix to the issue described here - see pnp#1235
@joelfmrodrigues joelfmrodrigues changed the base branch from master to dev June 27, 2022 15:26
@joelfmrodrigues
Copy link
Collaborator

@PeterWCox did you experience any issues with the import statement currently in the docs?
I have used this multiple times and never found issues. The other controls also seem to be importing in the same way

@PeterWCox
Copy link
Author

@joelfmrodrigues Yeah I tried to use exactly the same code as the docs but I got the same error as described in Issue #1235.

Weirdly enough I did scaffold a fresh project just now as a test, and the current import statement does work (?)

https://github.com/PeterWCox/spfx-people-picker-test

@joelfmrodrigues
Copy link
Collaborator

@PeterWCox not really sure why it didn't work before, it always worked for me.
Maybe the version of some tool or package was different?

@joelfmrodrigues
Copy link
Collaborator

@PeterWCox can we close this PR without merging and get back to it if you (or someone else) find the issue again?

@PeterWCox
Copy link
Author

Hey @joelfmrodrigues sorry for not responding sooner - yes lets close the issue.
Thanks for the assistance, Pete

@PeterWCox PeterWCox closed this Aug 24, 2022
@PeterWCox PeterWCox deleted the patch-1 branch August 24, 2022 06:10
@joelfmrodrigues
Copy link
Collaborator

Thanks, if you find it again please let us know :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants