Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the people picker freezing issue #130

Closed
wants to merge 1 commit into from
Closed

Fix the people picker freezing issue #130

wants to merge 1 commit into from

Conversation

gautamdsheth
Copy link
Contributor

@gautamdsheth gautamdsheth commented Sep 14, 2018

Q A
Bug fix? Y
New feature? N
New sample? N
Related issues? fixes #128 , #134

What's in this Pull Request?

As mentioned in #128, people picker component freezes when you try to add another user. This happens in the local as well as SharePoint workbench because primaryText is undefined. So, modified it to use secondaryText. This fixes the freezing issue and we are able to add multiple users

@estruyf
Copy link
Member

estruyf commented Sep 19, 2018

Thanks @gautamdsheth appreciate the fix, but implemented another fix myself. The issue why primaryText is undefined comes from the fact that in the latest versions of Office UI Fabric the properties changed. Before the NormalPeoplePicker used primaryText where it now uses text. All references of primaryText had to be updated in the code instead of falling back on secondaryText. Although this was a good approach, it does not cover all. Will close this PR without merging it, but you will receive credits in the changelog for this.

Thanks.

@estruyf estruyf closed this Sep 19, 2018
@gautamdsheth
Copy link
Contributor Author

Thanks @estruyf for such a detailed response. I should have investigated it more and should been more careful before sending this PR, apologies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants