Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DefaultUsers binding moved to ComponentDidUpdate and Error message update #141

Closed
wants to merge 2 commits into from

Conversation

AsishP
Copy link
Contributor

@AsishP AsishP commented Sep 22, 2018

…hanged error message to Text type instead of Messagebar type

Q A
Bug fix? [X ]
New feature? [X]
New sample? [ ]
Related issues? fixes #138, #135 , #140

What's in this Pull Request?

Please describe the changes in this PR. Sample description or details around bugs which are being fixed.
#135 , #138 - Allows defaultUsers to be updated and rebinded when props is updated or state changes
#140 - Changes the mandatory message issue type from MessageBar to normal div so it is easy to apply css

@codecov-io
Copy link

Codecov Report

Merging #141 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #141   +/-   ##
=======================================
  Coverage   80.63%   80.63%           
=======================================
  Files          10       10           
  Lines         346      346           
  Branches       78       71    -7     
=======================================
  Hits          279      279           
  Misses         44       44           
  Partials       23       23
Impacted Files Coverage Δ
src/loc/en-us.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9eb35e...74b3e82. Read the comment docs.

@estruyf
Copy link
Member

estruyf commented Oct 15, 2018

@AsishP thank you for the PR, but it contains code not related to the issues you want to solve. For example the API call to: const restAuthorApi = ${this.props.context.pageContext.web.absoluteUrl}/_api/web/lists/GetByTitle('Documents')/Items?$select=Id, Author/EMail&$expand=Author/EMail;. Could you please clean it up and do a new push?

@AsishP
Copy link
Contributor Author

AsishP commented Oct 16, 2018

@estruyf , actually that code was to test loading of users from a SharePoint site so we could test the fix for #138 and #135 , so pertaining to this PR, but it's fine I have commented those lines and submitted a new PR as couldn't update this one. Please let me know if that works.

@AsishP AsishP closed this Oct 16, 2018
@AsishP
Copy link
Contributor Author

AsishP commented Oct 16, 2018

Sorry reopening this PR, as the new PR didn't go through.. trying to reopen and check if this one goes through

@tomfairbs
Copy link

Wondering if there's any chance that this will be merged some time soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants