Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DefaultUsers binding moved to ComponentDidUpdate and Error message update (updated) #153

Merged
merged 2 commits into from
Oct 26, 2018

Conversation

AsishP
Copy link
Contributor

@AsishP AsishP commented Oct 16, 2018

Q A
Bug fix? [ X]
New feature? [ ]
New sample? [ ]
Related issues? fixes #138 , #135 , #140

What's in this Pull Request?

#135 , #138 - Allows defaultUsers to be updated and rebinded when props is updated or state changes
#140 - Changes the mandatory message issue type from MessageBar to normal div so it is easy to apply css

@codecov-io
Copy link

Codecov Report

Merging #153 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #153   +/-   ##
=======================================
  Coverage   80.63%   80.63%           
=======================================
  Files          10       10           
  Lines         346      346           
  Branches       71       71           
=======================================
  Hits          279      279           
  Misses         44       44           
  Partials       23       23
Impacted Files Coverage Δ
src/loc/en-us.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84fa336...acb3374. Read the comment docs.

@estruyf estruyf merged commit acb3374 into pnp:dev Oct 26, 2018
@estruyf
Copy link
Member

estruyf commented Oct 26, 2018

Thanks @AsishP this looked much better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants