Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for IFrameDialog Spinner issue, additional props for IFrameDialog #173

Merged
merged 2 commits into from
Dec 7, 2018

Conversation

AJIXuMuK
Copy link
Collaborator

@AJIXuMuK AJIXuMuK commented Nov 6, 2018

Q A
Bug fix? [X]
New feature? [x]
New sample? [ ]
Related issues? #154

What's in this Pull Request?

The PR contains fix of the issue #154 that appeared if IFrameDialog was used with cross-origin requests.
It also contains new props for IFrameDialog that are standard attributes for iframe HTML element

@codecov-io
Copy link

Codecov Report

Merging #173 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #173   +/-   ##
=======================================
  Coverage   80.63%   80.63%           
=======================================
  Files          10       10           
  Lines         346      346           
  Branches       71       78    +7     
=======================================
  Hits          279      279           
  Misses         44       44           
  Partials       23       23

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a903091...07c32fd. Read the comment docs.

@estruyf
Copy link
Member

estruyf commented Dec 7, 2018

Thanks @AJIXuMuK for the implemented fix

@estruyf estruyf merged commit 07c32fd into pnp:dev Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants