SecurityTrimmedControl - Extended to specific folder or item for remote list or lib #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## dev #271 +/- ##
=======================================
Coverage 72.33% 72.33%
=======================================
Files 17 17
Lines 759 759
Branches 146 156 +10
=======================================
Hits 549 549
Misses 163 163
Partials 47 47Continue to review full report at Codecov.
|
|
Thanks @Varuuna, I have merged your changed with some modifications to it. I have added two new enum properties to specify the type of security you want to check: |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this Pull Request?
This PR adds 2 optional properties to the SecurityTrimmedControl; folderPath and itemId that can be used when checking permission against a remote list or library. If either is present, we'll check the user's permission against a specified folder or item instead of the list itself.
A new function 'determineResource' is used to determine the url we send with our API call. It will prioritize 'itemId' first, if present, then 'folderPath', then finally 'remoteLibOrListUrl'.