Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added 1.15.0 control #394

Closed
wants to merge 2 commits into from
Closed

Added 1.15.0 control #394

wants to merge 2 commits into from

Conversation

PrasadKasireddy
Copy link
Contributor

Q A
Bug fix? [ No]
New feature? [ No]
New sample? [No ]
Related issues? fixes #X, partially #Y, mentioned in #Z

Documentation Issues - added controls which are included in release 1.15.0

What's in this Pull Request?

Please describe the changes in this PR. Sample description or details around bugs which are being fixed.

Guidance

  • You can delete this section when you are submitting the pull request.
  • Please update this PR information accordingly. We'll use this as part of our release notes in monthly communications.
  • Please target your PR to dev branch.

@PrasadKasireddy
## Available controls - add new controls.
3ab4cf4 
1) added duplicate IframeDialog - [IFrameDialog](./controls/IFrameDialog) (renders a Dialog with an iframe as a content) under the ## Available controls section
2) [Carousel](./controls/Carousel) (Control displays children elements with 'previous/next element' options) control is not added in alphabetical order
3) GridLayout & FilePicker are included in latest release 1.15.0 (https://sharepoint.github.io/sp-dev-fx-controls-react/about/release-notes/) However, these two control are is not listed under the ## Available controls section
@PrasadKasireddy
Added new control in order
f965755 
Filepicker & GidLayout
@AJIXuMuK
Copy link
Collaborator

Hi @PrasadKasireddy !
Thank you for the changes!
Could you please reference dev branch for the pull request?
The best way is to pull dev branch in you repo, create new branch based on dev, do the changes there and then create a commit.

Thanks!

AJIXuMuK added a commit that referenced this pull request Nov 15, 2019
@AJIXuMuK
Merge of #394
ac27bb5
@AJIXuMuK
Copy link
Collaborator

Hi @PrasadKasireddy!
I did it manually, so no need to recreate PR.

@AJIXuMuK AJIXuMuK closed this Nov 15, 2019
@AJIXuMuK AJIXuMuK added this to the 1.16.0 milestone Nov 15, 2019
@PrasadKasireddy
Copy link
Contributor Author

Thanks AjixMuk

@estruyf estruyf mentioned this pull request Dec 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PrasadKasireddy @AJIXuMuK