fix #405, when using drop down for time display, value is now formatt… #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atted properly with space between hours and designator.
Codecov Report
@@ Coverage Diff @@
## dev #409 +/- ##
=======================================
Coverage 73.31% 73.31%
=======================================
Files 18 18
Lines 802 802
Branches 164 164
=======================================
Hits 588 588
Misses 164 164
Partials 50 50Continue to review full report at Codecov.
|
|
Thanks for the fix @c-eiser13! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ed properly with space between hours and designator.
What's in this Pull Request?
In the HoursComponent of the DateTimePicker, updated the onChange function of the Dropdown control to pass the value to the TimeHelper.hoursValue function so it will be formatted as the DateTimePicker component expects it to be.
Previous: onChange(option.text)
New: onChange(TimeHelper.hoursValue(option.key as number, this.props.timeConvention))