Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[translate] - french translation for file picker #449

Merged
merged 2 commits into from
Jan 22, 2020
Merged

Conversation

PooLP
Copy link
Contributor

@PooLP PooLP commented Dec 19, 2019

French translation for file picker

@codecov-io
Copy link

Codecov Report

Merging #449 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #449   +/-   ##
=======================================
  Coverage   73.31%   73.31%           
=======================================
  Files          18       18           
  Lines         802      802           
  Branches      154      164   +10     
=======================================
  Hits          588      588           
  Misses        164      164           
  Partials       50       50

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7320d1e...3226431. Read the comment docs.

@AJIXuMuK
Copy link
Collaborator

Hi @PooLP!
Thank you very much for updating the localization!
We have added scripts to automatically translate missing keys... And now the PR you've created has conflicts with the dev branch.
I looked at the differences - and there are actual differences between auto translation and your manual translation.
Could you please verify the localization and update the PR?
Sorry for asking you to do additional job...

@PooLP
Copy link
Contributor Author

PooLP commented Jan 21, 2020

Hi,
It's ok for me with some little corrections ;)

@AJIXuMuK AJIXuMuK merged commit 20894d0 into pnp:dev Jan 22, 2020
@AJIXuMuK
Copy link
Collaborator

Thank you for reviewing and updating the translation!
It will be included in the next release.

@AJIXuMuK AJIXuMuK added this to the 1.17.0 milestone Jan 22, 2020
@estruyf estruyf mentioned this pull request Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants