Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed RichText link removing selected text. #455

Merged
merged 1 commit into from
Jan 10, 2020

Conversation

SharePickle
Copy link
Contributor

Q A
Bug fix? [x]
New feature? [ ]
New sample? [ ]
Related issues? fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?

Fixed RichText hyperlink removing selected text and not inserting formatted text back.

@codecov-io
Copy link

Codecov Report

Merging #455 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #455   +/-   ##
=======================================
  Coverage   73.31%   73.31%           
=======================================
  Files          18       18           
  Lines         802      802           
  Branches      164      164           
=======================================
  Hits          588      588           
  Misses        164      164           
  Partials       50       50

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cf8856...981ea7e. Read the comment docs.

@AJIXuMuK AJIXuMuK added this to the 1.17.0 milestone Jan 10, 2020
@AJIXuMuK AJIXuMuK added the status:fixed-next-drop Issue will be fixed in upcoming release. label Jan 10, 2020
@AJIXuMuK AJIXuMuK merged commit 245fa31 into pnp:dev Jan 10, 2020
@AJIXuMuK
Copy link
Collaborator

Thanks @SharePickle for fixing this. The fix will be available in the next version, but you can already test it in beta version.

@estruyf estruyf mentioned this pull request Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:fixed-next-drop Issue will be fixed in upcoming release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants