#292 added ComboBoxListItemPicker SecurityTrimmedControl - No permissions template #307

[mgwojciech]

Q	A
Bug fix?	[ ]
New feature?	[*]
New sample?	[ ]
Related issues?	fixes #292

What's in this Pull Request

Added ComboBoxListItemPicker - list item picker based on Fabric UI Combo Box component.
To improve testability this PR also included mock for RequestClient (from pnpjs).
This means that the SPHttpClient used in Props is also the one from pnpjs (not from spfx)

Example usage:
const element: React.ReactElement = React.createElement(
ComboBoxListItemPicker,
{
webUrl: this.context.pageContext.web.absoluteUrl,
spHttpClient: new SPHttpClient(),
columnInternalName: "Title",
listId: "490fae3c-f8cb-4b50-9737-f2c94f6b6727",
filter: "Id gt 0",
itemLimit: 50,
defaultSelectedItems: [{Id:2, Title: "Test 2"}],
//
onSelectedItem:(selected)=>{
console.log(selected);
}
}
);

ReactDom.render(element, this.domElement);

Or provide defaultSelectedItems with Id only:
const element: React.ReactElement = React.createElement(
ComboBoxListItemPicker,
{
webUrl: this.context.pageContext.web.absoluteUrl,
spHttpClient: new SPHttpClient(),
columnInternalName: "Title",
listId: "490fae3c-f8cb-4b50-9737-f2c94f6b6727",
filter: "Id gt 0",
itemLimit: 50,
defaultSelectedItems: [2],
//
onSelectedItem:(selected)=>{
console.log(selected);
}
}
);

ReactDom.render(element, this.domElement);

[msftclas]

All CLA requirements met.

[codecov-io]

Codecov Report

Merging #474 into dev will increase coverage by 0.07%.
The diff coverage is 74.11%.

@@            Coverage Diff             @@
##              dev     #474      +/-   ##
==========================================
+ Coverage   73.31%   73.39%   +0.07%     
==========================================
  Files          18       21       +3     
  Lines         802      887      +85     
  Branches      154      175      +21     
==========================================
+ Hits          588      651      +63     
- Misses        164      176      +12     
- Partials       50       60      +10

Impacted Files	Coverage Δ
src/common/dal/ListItemRepository.ts	61.53% <61.53%> (ø)
src/common/mocks/RequestClientMock.ts	67.85% <67.85%> (ø)
...controls/listItemPicker/ComboBoxListItemPicker.tsx	81.81% <81.81%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3540d1...85a37af. Read the comment docs.

[estruyf]

@mgwojciech thanks for the control + enhancement.

In the future, please do a PR per control change. There were some issues in the ComboBoxListItemPicker which are now solved. I had to do updates to it first in order to get the SecurityTrimmedControl merged.

[mgwojciech]

Sure, I will.
Thanks.