Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New List Picker Feature #60

Merged
merged 8 commits into from
Apr 25, 2018
Merged

New List Picker Feature #60

merged 8 commits into from
Apr 25, 2018

Conversation

parithon
Copy link
Contributor

@parithon parithon commented Apr 9, 2018

Q A
Bug fix? [ ]
New feature? [ x ]
New sample? [ ]
Related issues? Adds a list picker control requested on issue #34

What's in this Pull Request?

Included is a service to pull the lists of the current site and provide a drop down control with the available lists. As an aside, this is my first ever pull request.

@msftclas
Copy link

msftclas commented Apr 9, 2018

CLA assistant check
All CLA requirements met.

@codecov-io
Copy link

codecov-io commented Apr 9, 2018

Codecov Report

Merging #60 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev      #60   +/-   ##
=======================================
  Coverage   78.16%   78.16%           
=======================================
  Files          10       10           
  Lines         348      348           
  Branches       72       72           
=======================================
  Hits          272      272           
  Misses         56       56           
  Partials       20       20

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8226fdd...feaf790. Read the comment docs.

@estruyf estruyf merged commit feaf790 into pnp:dev Apr 25, 2018
@estruyf
Copy link
Member

estruyf commented Apr 25, 2018

@parithon thank you for this new control, I did various changes to align code structure and fix some small issues.

Would you be able to write the documentation for this control?

@estruyf estruyf added this to the 1.3.0 milestone Apr 25, 2018
@estruyf estruyf self-requested a review April 25, 2018 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants